Issue 5682043: Set context property to allow half-measure beaming in 3/4 (Issue 2246)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5682043: Set context property to allow half-measure beaming in 3/4 (Issue 2246) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Carl

Modified:
11 years, 11 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Set context property to allow half-measure beaming in 3/4 (Issue 2246)

Patch Set 1 #

Patch Set 2 : Limit full-measure and half-measure beaming to 1/8 beams #

Patch Set 3 : Fix regression test results #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -29 lines)			Patch
M	Documentation/notation/rhythms.itely	View		1 chunk	+22 lines, -8 lines	0 comments	Download
A	input/regression/autobeam-3-4-rules.ly	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
M	input/regression/multiple-time-sig-settings.ly	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ly/engraver-init.ly	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	scm/auto-beam.scm	View	1 2	4 chunks	+37 lines, -11 lines	1 comment	Download
M	scm/define-context-properties.scm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	scm/time-signature-settings.scm	View	1 2	4 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

11 years, 11 months ago (2012-05-28 01:39:25 UTC) #1

http://codereview.appspot.com/5682043/diff/6001/scm/auto-beam.scm
File scm/auto-beam.scm (right):

http://codereview.appspot.com/5682043/diff/6001/scm/auto-beam.scm#newcode118
scm/auto-beam.scm:118: ;; #t if beam is to start
It looks like the caller asks this routine one of two questions:
 May I start a beam here?
 Must I end the current beam here?  

The 'start' decision gives use the power to prevent beams from starting
mid-measure, but we are not given the power to prevent ending a beam
mid-measure, as in { c8[ c] c r4. }

Given either { c8 c c r4. } or { c8 c c c r4 }
this routine is given the same information, and asked the same question, about
ending the beam after c8 c, so we cannot hope that it will give different
answers.

Expand All Messages | Collapse All Messages