Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 5677074: code review 5677074: misc/dist/windows: distro builder updates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Joe Poirier
Modified:
13 years, 3 months ago
Reviewers:
CC:
golang-dev, brainman, rsc
Visibility:
Public.

Description

misc/dist/windows: distro builder updates files moved from misc/windows, bash packager file replaced with Windows batch file

Patch Set 1 #

Patch Set 2 : diff -r 51793ab42fa9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3cec8428d4d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2dc817ab3653 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M misc/dist/windows/README View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A misc/dist/windows/dist.bat View 1 1 chunk +54 lines, -0 lines 0 comments Download
M misc/dist/windows/godocserver.bat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M misc/dist/windows/goenv.bat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M misc/dist/windows/installer.wxs View 1 0 chunks +-1 lines, --1 lines 0 comments Download
R misc/windows/LICENSE View 1 Binary file 0 comments Download
R misc/windows/package.bash View 1 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 5
Joe Poirier
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2012-02-17 06:15:36 UTC) #1
Joe Poirier
I'm assuming the WiX msi installer is still part of the plan? If so, I ...
13 years, 3 months ago (2012-02-17 07:49:42 UTC) #2
brainman
Please, no batch files. These are unusable - hard to write, easy to make mistakes, ...
13 years, 3 months ago (2012-02-17 08:28:12 UTC) #3
rsc
LGTM Joe agreed to maintain the Windows distribution mechanism. If he wants to start with ...
13 years, 3 months ago (2012-02-17 14:05:12 UTC) #4
Joe Poirier
13 years, 3 months ago (2012-02-17 17:07:44 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=0c7e6d59edad ***

misc/dist/windows:  distro builder updates

files moved from misc/windows, bash packager file replaced with Windows batch
file

R=golang-dev, alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/5677074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b