code review 5677060: sort: add interface examples

sort: add interface examples

[adg, 2012-02-16 00:26:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitzgoog, 2012-02-16 00:33:18]

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
File src/pkg/sort/example_reverse_test.go (right):

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:15: // This embedded Interface allows
Rerverse to inherit the methods of
Reverse, not Rerverse.

I thought we avoided the word "inherit"?

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:22: return !r.Interface.Less(i, j)
return r.Interface.Less(j, i)  ?

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:27: r := Reverse{sort.IntSlice(s)}
I'd move this into the next line. the variable r doesn't add anything.

sort.Sort(Reverse{sort.IntSlice(s)})

... seems to read better.

[r, 2012-02-16 00:35:43]

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
File src/pkg/sort/example_interface_test.go (right):

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:10: )
type Grams int
func (g Grams) String() { return fmt.Sprintf("%dg", int(g)) }

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:14: Weight int // in grams
s/int.*/Grams

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:28: func (s ByWeight) Less(i, j int) bool
{ return s.Organs[i].Weight < s.Organs[j].Weight }
s2/Weight/Grams/g

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:67: fmt.Printf("%-8s (%d grams)\n",
o.Name, o.Weight)
s/%d grams/%s/

[adg, 2012-02-16 00:47:50]

PTAL

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
File src/pkg/sort/example_interface_test.go (right):

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:10: )
On 2012/02/16 00:35:44, r wrote:
> type Grams int
> func (g Grams) String() { return fmt.Sprintf("%dg", int(g)) }
> 

Done.

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:14: Weight int // in grams
On 2012/02/16 00:35:44, r wrote:
> s/int.*/Grams

Done.

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:28: func (s ByWeight) Less(i, j int) bool
{ return s.Organs[i].Weight < s.Organs[j].Weight }
On 2012/02/16 00:35:44, r wrote:
> s2/Weight/Grams/g

Done.

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_interfac...
src/pkg/sort/example_interface_test.go:67: fmt.Printf("%-8s (%d grams)\n",
o.Name, o.Weight)
On 2012/02/16 00:35:44, r wrote:
> s/%d grams/%s/

Done.

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
File src/pkg/sort/example_reverse_test.go (right):

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:15: // This embedded Interface allows
Rerverse to inherit the methods of
On 2012/02/16 00:33:18, bradfitzgoog wrote:
> Reverse, not Rerverse.

Done.

> I thought we avoided the word "inherit"?

Got a better one? :-)

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:22: return !r.Interface.Less(i, j)
On 2012/02/16 00:33:18, bradfitzgoog wrote:
> return r.Interface.Less(j, i)  ?

Done.

http://codereview.appspot.com/5677060/diff/2001/src/pkg/sort/example_reverse_...
src/pkg/sort/example_reverse_test.go:27: r := Reverse{sort.IntSlice(s)}
On 2012/02/16 00:33:18, bradfitzgoog wrote:
> I'd move this into the next line. the variable r doesn't add anything.
> 
> sort.Sort(Reverse{sort.IntSlice(s)})
> 
> ... seems to read better.

Done.

[r, 2012-02-16 00:52:55]

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
File src/pkg/sort/example_interface_test.go (right):

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:18: Grams Grams
my edit was
Weight Grams
which reads better throughout

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:26: type ByName struct{ Organs }
worth a doc comment here and on ByGrams to say this is a conversion trick

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:30: type ByGrams struct{ Organs }
i'd prefer ByWeight

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:71: fmt.Printf("%-8s (%s)\n", o.Name,
o.Grams)
how about s/%s/%v/g

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_reverse_tes...
File src/pkg/sort/example_reverse_test.go (right):

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_reverse_tes...
src/pkg/sort/example_reverse_test.go:15: // This embedded Interface allows
Reverse to inherit the methods of
s/inherit/use/

[adg, 2012-02-16 01:52:12]

PTAL

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
File src/pkg/sort/example_interface_test.go (right):

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:18: Grams Grams
On 2012/02/16 00:52:55, r wrote:
> my edit was
> Weight Grams
> which reads better throughout

Done.

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:26: type ByName struct{ Organs }
On 2012/02/16 00:52:55, r wrote:
> worth a doc comment here and on ByGrams to say this is a conversion trick

Done.

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:30: type ByGrams struct{ Organs }
On 2012/02/16 00:52:55, r wrote:
> i'd prefer ByWeight

Done.

http://codereview.appspot.com/5677060/diff/5/src/pkg/sort/example_interface_t...
src/pkg/sort/example_interface_test.go:71: fmt.Printf("%-8s (%s)\n", o.Name,
o.Grams)
On 2012/02/16 00:52:55, r wrote:
> how about s/%s/%v/g

Done.

[r, 2012-02-16 02:07:58]

LGTM
i like the embedded organs

[adg, 2012-02-16 02:16:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=df612f0d549f ***

sort: add interface examples

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5677060