Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 5677059: code review 5677059: goauth2: fix IsExpired test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by adg
Modified:
14 years, 4 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

goauth2: fix IsExpired test

Patch Set 1 #

Patch Set 2 : diff -r a7ddadea4dc3 https://code.google.com/p/goauth2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M oauth/oauth.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2
14 years, 4 months ago (2012-02-15 23:07:34 UTC) #1
bradfitz
LGTM fix IsExpired _test_? :-) On Thu, Feb 16, 2012 at 10:07 AM, <adg@golang.org> wrote: ...
14 years, 4 months ago (2012-02-15 23:08:14 UTC) #2
adg
*** Submitted as 5da4459beecc *** goauth2: fix IsExpired test R=bradfitz CC=golang-dev http://codereview.appspot.com/5677059
14 years, 4 months ago (2012-02-15 23:09:52 UTC) #3
adg
14 years, 4 months ago (2012-02-15 23:10:12 UTC) #4
On 16 February 2012 10:08, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
> fix IsExpired _test_?  :-)

It's the test in IsExpired.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b