Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2
LGTM fix IsExpired _test_? :-) On Thu, Feb 16, 2012 at 10:07 AM, <adg@golang.org> wrote: > Reviewers: bradfitz, > > Message: > Hello bradfitz (cc: golang-dev@googlegroups.com), > > I'd like you to review this change to > https://code.google.com/p/**goauth2 <https://code.google.com/p/goauth2> > > > Description: > goauth2: fix IsExpired test > > Please review this at http://codereview.appspot.com/**5677059/<http://codereview.appspot.com/5677059/> > > Affected files: > M oauth/oauth.go > > > Index: oauth/oauth.go > ==============================**==============================**======= > --- a/oauth/oauth.go > +++ b/oauth/oauth.go > @@ -76,7 +76,7 @@ > if t.Expiry.IsZero() { > return false > } > - return t.Expiry.After(time.Now()) > + return t.Expiry.Before(time.Now()) > } > > // Transport implements http.RoundTripper. When configured with a valid > > >
*** Submitted as 5da4459beecc *** goauth2: fix IsExpired test R=bradfitz CC=golang-dev http://codereview.appspot.com/5677059
On 16 February 2012 10:08, Brad Fitzpatrick <bradfitz@golang.org> wrote: > LGTM > > fix IsExpired _test_? :-) It's the test in IsExpired.