Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5677056: Split extensions into servlet and appengine (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by rmistry
Modified:
12 years, 2 months ago
Reviewers:
yanivi
Base URL:
https://google-oauth-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Depends on http://codereview.appspot.com/5675064/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing code review comments #

Patch Set 3 : Attempt #3 #

Patch Set 4 : Attempt #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+679 lines, --7 lines) Patch
M google-oauth-client-appengine/.classpath View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/.project View 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client-appengine/.settings/org.eclipse.jdt.core.prefs View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/.settings/org.eclipse.jdt.ui.prefs View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/pom.xml View 3 chunks +9 lines, -12 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/AbstractAppEngineCallbackServlet.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/AbstractAppEngineFlowServlet.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/AbstractAppEngineTwoLeggedFlowServlet.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/AppEngineServletUtils.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/SignedTokenGenerator.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/helpers/AccessAppResource.java View 0 chunks +-1 lines, --1 lines 0 comments Download
google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/helpers/AppAssertionCredential.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/helpers/AppAssertionFlow.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/helpers/package-info.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/package-info.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-assembly/pom.xml View 1 chunk +5 lines, -1 line 0 comments Download
A google-oauth-client-servlet/.classpath View 1 chunk +9 lines, -0 lines 0 comments Download
A google-oauth-client-servlet/.project View 1 chunk +23 lines, -0 lines 0 comments Download
A google-oauth-client-servlet/.settings/org.eclipse.jdt.core.prefs View 1 chunk +380 lines, -0 lines 0 comments Download
A google-oauth-client-servlet/.settings/org.eclipse.jdt.ui.prefs View 1 chunk +119 lines, -0 lines 0 comments Download
A google-oauth-client-servlet/pom.xml View 1 chunk +143 lines, -0 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/ThreeLeggedFlow.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/TwoLeggedFlow.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacThreeLeggedFlow.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth2/draft10/OAuth2Credential.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth2/draft10/OAuth2ThreeLeggedFlow.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/oauth2/draft10/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/servlet/auth/AbstractCallbackServlet.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/servlet/auth/AbstractFlowUserServlet.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/servlet/auth/AbstractTwoLeggedFlowServlet.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/servlet/auth/package-info.java View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M jdiff.xml View 1 chunk +2 lines, -1 line 0 comments Download
M pom.xml View 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rmistry
12 years, 2 months ago (2012-02-15 22:20:18 UTC) #1
yanivi
http://codereview.appspot.com/5677056/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java File google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java (right): http://codereview.appspot.com/5677056/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java#newcode2 google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java:2: * Copyright (c) 2011 Google Inc. For some reason, ...
12 years, 2 months ago (2012-02-16 04:43:26 UTC) #2
rmistry
http://codereview.appspot.com/5677056/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java File google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java (right): http://codereview.appspot.com/5677056/diff/1/google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java#newcode2 google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/auth/helpers/Credential.java:2: * Copyright (c) 2011 Google Inc. On 2012/02/16 04:43:27, ...
12 years, 2 months ago (2012-02-16 15:37:28 UTC) #3
yanivi
12 years, 2 months ago (2012-02-16 16:14:33 UTC) #4 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b