Issue 5676094: test/run: honor $TMPDIR

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5676094: test/run: honor $TMPDIR (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by minux1

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

test/run: honor $TMPDIR

Patch Set 1 #

Patch Set 2 : diff -r eaad9c873d9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eaad9c873d9b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eaad9c873d9b https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	test/run	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-02-18 20:47:07 UTC) #1

rsc

Please use RUNFILE="${TMPDIR:-/tmp}/gorun-$$-$USER" TMP1FILE="${TMPDIR:-/tmp}/gotest1-$$-$USER" TMP2FILE="${TMPDIR:-/tmp}/gotest2-$$-$USER" to make sure the dir gets quoted even if $TMPDIR ...

13 years, 3 months ago (2012-02-18 20:52:38 UTC) #2

minux1

PTAL. On 2012/02/18 20:52:38, rsc wrote: > Please use > > RUNFILE="${TMPDIR:-/tmp}/gorun-$$-$USER" > TMP1FILE="${TMPDIR:-/tmp}/gotest1-$$-$USER" > ...

13 years, 3 months ago (2012-02-18 21:00:10 UTC) #3

rsc

13 years, 3 months ago (2012-02-18 21:15:15 UTC) #5

*** Submitted as 3cb3a8a7d6ae ***

test/run: honor $TMPDIR

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5676094

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages