code review 5676079: math/rand: Intn etc. should panic if their argument is <= 0.

math/rand: Intn etc. should panic if their argument is <= 0.

I am making a unilateral decision here. I could also settle for returning 0,
as long it's documented, but I argue that it's equivalent to an index
out of bounds.

Fixes issue 2892.

[r, 2012-02-17 12:22:48]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2012-02-17 12:44:17]

LGTM

but s/negative/non-positive/ or similar. Zero is neither positive nor
negative.

[rsc, 2012-02-17 14:34:44]

LGTM

invalid is fine too

[r, 2012-02-17 21:53:13]

*** Submitted as 45c313581bc4 ***

math/rand: Intn etc. should panic if their argument is <= 0.

I am making a unilateral decision here. I could also settle for returning 0,
as long it's documented, but I argue that it's equivalent to an index
out of bounds.

Fixes issue 2892.

R=golang-dev, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5676079