Allow thread safety attributes on function definitions.

[delesley, 2012-02-15 19:20:43]

http://codereview.appspot.com/5676055/diff/1/lib/Parse/ParseDecl.cpp
File lib/Parse/ParseDecl.cpp (right):

http://codereview.appspot.com/5676055/diff/1/lib/Parse/ParseDecl.cpp#newcode785
lib/Parse/ParseDecl.cpp:785: LA.D->isFunctionOrFunctionTemplate();
Already fixed these tabs.

[Richard Smith, 2012-02-15 21:10:14]

http://codereview.appspot.com/5676055/diff/1/include/clang/Basic/DiagnosticPa...
File include/clang/Basic/DiagnosticParseKinds.td (right):

http://codereview.appspot.com/5676055/diff/1/include/clang/Basic/DiagnosticPa...
include/clang/Basic/DiagnosticParseKinds.td:156: InGroup<Attributes>;
This matches gcc's diagnostic, but isn't really true: attributes are permitted
at the start of a function definition.

http://codereview.appspot.com/5676055/diff/1/test/SemaCXX/warn-thread-safety-...
File test/SemaCXX/warn-thread-safety-analysis.cpp (right):

http://codereview.appspot.com/5676055/diff/1/test/SemaCXX/warn-thread-safety-...
test/SemaCXX/warn-thread-safety-analysis.cpp:1967: }
Please put these tests somewhere which is not specific to thread safety analysis
attributes. test/Parser/attributes.c, maybe. Please also add tests for:
 * __attribute__(()), which gcc accepts on function definitions.
 * attributes at the start of function definitions, which both gcc and clang
accept and handle.

[delesley, 2012-02-16 00:23:47]

http://codereview.appspot.com/5676055/diff/1/include/clang/Basic/DiagnosticPa...
File include/clang/Basic/DiagnosticParseKinds.td (right):

http://codereview.appspot.com/5676055/diff/1/include/clang/Basic/DiagnosticPa...
include/clang/Basic/DiagnosticParseKinds.td:156: InGroup<Attributes>;
On 2012/02/15 21:10:14, Richard Smith wrote:
> This matches gcc's diagnostic, but isn't really true: attributes are permitted
> at the start of a function definition.

Reworded.

http://codereview.appspot.com/5676055/diff/1/test/SemaCXX/warn-thread-safety-...
File test/SemaCXX/warn-thread-safety-analysis.cpp (right):

http://codereview.appspot.com/5676055/diff/1/test/SemaCXX/warn-thread-safety-...
test/SemaCXX/warn-thread-safety-analysis.cpp:1967: }
On 2012/02/15 21:10:14, Richard Smith wrote:
> Please put these tests somewhere which is not specific to thread safety
analysis
> attributes. test/Parser/attributes.c, maybe. Please also add tests for:
>  * __attribute__(()), which gcc accepts on function definitions.
>  * attributes at the start of function definitions, which both gcc and clang
> accept and handle.

Done.

[Richard Smith, 2012-02-16 01:04:12]

http://codereview.appspot.com/5676055/diff/10/include/clang/Basic/DiagnosticG...
File include/clang/Basic/DiagnosticGroups.td (right):

http://codereview.appspot.com/5676055/diff/10/include/clang/Basic/DiagnosticG...
include/clang/Basic/DiagnosticGroups.td:365: def GccCompat :
DiagGroup<"gcc-compatibility">;
gcc-compat rather than gcc-compatibility, for consistency with c++-compat,
c++98-compat and c++11-compat.

http://codereview.appspot.com/5676055/diff/10/include/clang/Basic/DiagnosticP...
File include/clang/Basic/DiagnosticParseKinds.td (right):

http://codereview.appspot.com/5676055/diff/10/include/clang/Basic/DiagnosticP...
include/clang/Basic/DiagnosticParseKinds.td:155: "GCC does not allow attribute
\'%0\' in this position on a function definition">,
You don't need to escape these 's. Also, please wrap this to get under 80
columns. tablegen supports C-style string concatenations.