Issue 5676054: code review 5676054: go spec: struct comparison only compares non-blank fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5676054: code review 5676054: go spec: struct comparison only compares non-blank fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by gri

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc, r, iant

Visibility:
Public.

Description

go spec: struct comparison only compares non-blank fields Fixes issue 3031.

Patch Set 1 #

Patch Set 2 : diff -r a9e12ba1c6ea https://code.google.com/p/go #

Patch Set 3 : diff -r a9e12ba1c6ea https://code.google.com/p/go #

Patch Set 4 : diff -r 394949280114 https://code.google.com/p/go #

Patch Set 5 : diff -r 97c23760a7e5 https://code.google.com/p/go #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years, 3 months ago (2012-02-15 17:55:06 UTC) #1

gri

Updated CL description (removed "Proposal"), updated date. Ian, you're ok with this? - gri On ...

13 years, 3 months ago (2012-02-16 20:51:18 UTC) #4

gri

13 years, 3 months ago (2012-02-16 22:13:20 UTC) #6

*** Submitted as 9078c7ac1b79 ***

go spec: struct comparison only compares non-blank fields

Fixes issue 3031.

R=golang-dev, rsc, r, iant
CC=golang-dev
http://codereview.appspot.com/5676054

Expand All Messages | Collapse All Messages