code review 5675093: runtime: API

runtime: API

Delete Alloc, Free, Lookup, Semacquire, Semrelease

Fixes issue 2955.

[rsc, 2012-02-18 21:34:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2012-02-18 21:41:24]

i have no idea what's going on.

also: go1.{tmpl,html}

http://codereview.appspot.com/5675093/diff/2014/src/pkg/sync/runtime_sema_tes...
File src/pkg/sync/runtime_sema_test.go (right):

http://codereview.appspot.com/5675093/diff/2014/src/pkg/sync/runtime_sema_tes...
src/pkg/sync/runtime_sema_test.go:30: Runtime_Semacquire(&sem.sem)
here is Runtime; in the other files it was runtime. what's the story?

http://codereview.appspot.com/5675093/diff/2014/src/pkg/sync/waitgroup.go
File src/pkg/sync/waitgroup.go (right):

http://codereview.appspot.com/5675093/diff/2014/src/pkg/sync/waitgroup.go#new...
src/pkg/sync/waitgroup.go:60: runtime_Semrelease(wg.sema)
i don't understand where this is coming from

[rsc, 2012-02-18 23:16:30]

PTAL

I forgot two important new files in the last CL,
runtime.go and export_test.go in package sync.

I'll edit go1.* once 5672080 is in.

Russ

[bradfitz, 2012-02-18 23:27:23]

LGTM

On Sat, Feb 18, 2012 at 3:16 PM, Russ Cox <rsc@golang.org> wrote:

> PTAL
>
> I forgot two important new files in the last CL,
> runtime.go and export_test.go in package sync.
>
> I'll edit go1.* once 5672080 is in.
>
> Russ
>

[rsc, 2012-02-19 05:11:47]

*** Submitted as 1b7151fd97d4 ***

runtime: API

Delete Alloc, Free, Lookup, Semacquire, Semrelease

Fixes issue 2955.

R=golang-dev, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5675093