Issue 5675087: code review 5675087: encoding/gob: cache engine for user type, not base type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5675087: code review 5675087: encoding/gob: cache engine for user type, not base type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

encoding/gob: cache engine for user type, not base type When we build the encode engine for a recursive type, we mustn't disregard the indirections or we can try to reuse an engine at the wrong indirection level. Fixes issue 3026.

Patch Set 1 #

Patch Set 2 : diff -r 78e6a187e945 https://code.google.com/p/go/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	src/pkg/encoding/gob/decode.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/encoding/gob/encoder_test.go	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 3 months ago (2012-02-18 03:25:26 UTC) #1

13 years, 3 months ago (2012-02-18 03:38:45 UTC) #3

*** Submitted as 9e29da909bf9 ***

encoding/gob: cache engine for user type, not base type
When we build the encode engine for a recursive type, we
mustn't disregard the indirections or we can try to reuse an
engine at the wrong indirection level.

Fixes issue 3026.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5675087

Expand All Messages | Collapse All Messages