Issue 5675073: code review 5675073: net, os, syscall: delete os.EPLAN9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5675073: code review 5675073: net, os, syscall: delete os.EPLAN9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mikio

Modified:
13 years, 2 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

net, os, syscall: delete os.EPLAN9 Also fixes plan9 cross-build.

Patch Set 1 : diff -r 4b3cca9c3331 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 4b3cca9c3331 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9fe468a8001a https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -45 lines)			Patch
M	src/pkg/net/file_plan9.go	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pkg/net/iprawsock_plan9.go	View		5 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/net/ipsock_plan9.go	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pkg/net/lookup_plan9.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/net/tcpsock_plan9.go	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/net/udpsock_plan9.go	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/net/unixsock_plan9.go	View		5 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/os/exec/lp_plan9.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	src/pkg/os/signal/signal_stub.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_plan9_386.go	View		2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-02-17 01:15:04 UTC) #1

mikio

13 years, 2 months ago (2012-02-17 01:59:35 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=86464104e425 ***

net, os, syscall: delete os.EPLAN9

Also fixes plan9 cross-build.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5675073

Expand All Messages | Collapse All Messages