Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 5675070: code review 5675070: path/filepath: fix test on darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

path/filepath: fix test on darwin /tmp being itself a symlink causes problems for the test, so use / as the absolute path.

Patch Set 1 #

Patch Set 2 : diff -r 46f3a9f35a4a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/path/filepath/path_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 4 months ago (2012-02-16 22:51:05 UTC) #1
gri
LGTM On Thu, Feb 16, 2012 at 2:51 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 4 months ago (2012-02-16 22:53:49 UTC) #2
r
13 years, 4 months ago (2012-02-16 22:56:17 UTC) #3
*** Submitted as 2bb05796f8fc ***

path/filepath: fix test on darwin
/tmp being itself a symlink causes problems for the test, so use / as the
absolute path.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5675070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b