code review 5675062: go/printer: don't lose relevant parentheses when rewrit...

go/printer: don't lose relevant parentheses when rewriting selector expressions

Also: Simplified handling of selector expressions. As a result, complicated
multi-line expressions containing selectors and calls/indices with arguments
broken accross lines don't get indented the same way as before, but the change
is minimal (see tests) and there's no such code in the std library. It seems
a worthwhile compromise given the much simpler code.

Applied gofmt -w $GOROOT/src $GOROOT/misc .

Fixes issue 1847.

[gri, 2012-02-15 20:02:22]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-02-15 20:14:04]

LGTM

I agree that the change is a very rare case.
If it comes up in real code we can deal with it then.

[gri, 2012-02-15 20:25:39]

*** Submitted as f76d6627f6b1 ***

go/printer: don't lose relevant parentheses when rewriting selector expressions

Also: Simplified handling of selector expressions. As a result, complicated
multi-line expressions containing selectors and calls/indices with arguments
broken accross lines don't get indented the same way as before, but the change
is minimal (see tests) and there's no such code in the std library. It seems
a worthwhile compromise given the much simpler code.

Applied gofmt -w $GOROOT/src $GOROOT/misc .

Fixes issue 1847.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5675062