Issue 5675055: code review 5675055: weekly.2012-02-14

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5675055: code review 5675055: weekly.2012-02-14 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by adg

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds, r, mikio

Visibility:
Public.

Patch Set 2 : diff -r bfeb2a9eb288 https://go.googlecode.com/hg #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View	1	1 chunk	+119 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 3 months ago (2012-02-15 02:58:30 UTC) #1

LGTM is that all you got? http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html#newcode25 doc/devel/weekly.html:25: The os pacakge's ...

13 years, 3 months ago (2012-02-15 03:06:46 UTC) #3

mikio

http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html#newcode31 doc/devel/weekly.html:31: The os/signal package has been revived.

13 years, 3 months ago (2012-02-15 03:14:21 UTC) #4

bradfitzgoog

http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5675055/diff/1/doc/devel/weekly.html#newcode26 doc/devel/weekly.html:26: os/exec package and time.Now instead. The ShellExpand function was ...

13 years, 3 months ago (2012-02-15 03:15:34 UTC) #5

adg

13 years, 3 months ago (2012-02-15 03:15:39 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=3697ea0639cb ***

weekly.2012-02-14

R=golang-dev, dsymonds, r, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5675055

Expand All Messages | Collapse All Messages