Issue 5674071: code review 5674071: encoding/gob: catch internal error when it happens

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674071: code review 5674071: encoding/gob: catch internal error when it happens (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

encoding/gob: catch internal error when it happens It was being skipped due to an oversight. Also adjust naming parameters for map type construction - makes debugging easier. Prelude to issue 3026.

Patch Set 1 #

Patch Set 2 : diff -r b524787e7542 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c9dae91ce714 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 87b98f188120 https://code.google.com/p/go/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	src/pkg/encoding/gob/decode.go	View	1	4 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-02-16 10:43:07 UTC) #1

13 years, 3 months ago (2012-02-16 20:08:01 UTC) #3

*** Submitted as 8cba5a2dc484 ***

encoding/gob: catch internal error when it happens
It was being skipped due to an oversight.
Also adjust naming parameters for map type construction - makes debugging
easier.
Prelude to issue 3026.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5674071

Expand All Messages | Collapse All Messages