code review 5674050: encoding/xml: add MarshalIndent and move the example

encoding/xml: add MarshalIndent and move the example

An unindented XML example is hard to follow. MarshalIndent
allows moving the example over to a test file (and fixing it).

[niemeyer, 2012-02-15 04:58:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[niemeyer, 2012-02-15 05:02:14]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-15 05:07:34]

why did it go away? there was a reason.


changeset:   8893:85fe786bbd63
user:        Kyle Lemons <kyle@kylelemons.net>
date:        Mon Jun 27 19:07:28 2011 -0400
summary:     xml: add Marshal and MarshalIndent

[gustavo_niemeyer.net, 2012-02-15 05:40:22]

On Wed, Feb 15, 2012 at 03:07,  <r@golang.org> wrote:
> why did it go away? there was a reason.

The log is bogus since in fact it never went in. All I can find is a
comment from Russ in the original CL saying:

"""
let's leave this for a different CL.
would be better as a filter, like json.Indent is,
so you can apply it to any xml.
"""

If that's the reasoning, then:

- That was 8 months ago
- The change I'm proposing is trivial if compared to a filtering implementation
- The interface is the same, so there's no problem in changing it later

-- 
Gustavo Niemeyer
http://niemeyer.net
http://niemeyer.net/plus
http://niemeyer.net/twitter
http://niemeyer.net/blog

-- I'm not absolutely sure of anything.

[r2, 2012-02-15 07:14:04]

ok, no objections from me, but i defer XML package reviews to people who use
XML.

-rob

[rsc, 2012-02-15 14:04:02]

LGTM

[niemeyer, 2012-02-16 04:01:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=e5c8997145d9 ***

encoding/xml: add MarshalIndent and move the example

An unindented XML example is hard to follow. MarshalIndent
allows moving the example over to a test file (and fixing it).

R=golang-dev, r, gustavo, r, rsc
CC=golang-dev
http://codereview.appspot.com/5674050