code review 5673099: misc/dist/windows: ongoing dev

misc/dist/windows: ongoing dev

Added the (properly formatted) license file back,
the installer adds go\bin to the system PATH now,
the output package names are in line with the linux
and darwin versions, dist.bat extracts GOARCH in a
sane way, readme cleanup.

Tested on Windows 7 only. It would be helpful if
someone else could give it a try. See the readme
for details.

[Joe Poirier, 2012-02-19 01:19:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[Joe Poirier, 2012-02-20 03:44:30]

PING (more updates waiting)

[bradfitz, 2012-02-20 03:50:57]

LGTM

Why is LICENSE a binary file?

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/README
File misc/dist/windows/README (right):

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/README#newc...
misc/dist/windows/README:23: Run dist.bat from a shell window or click on the
batch file.
s/shell/command prompt/?  (not cygwin, right?)

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat
File misc/dist/windows/dist.bat (right):

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat#ne...
misc/dist/windows/dist.bat:41: del /S /Q *.zip>NUL
is this always run from a temp directory where *.zip is safe to delete?  or
should the pattern be more restrictive?

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat#ne...
misc/dist/windows/dist.bat:51: del /S /Q *.msi>NUL
likewise

[Joe Poirier, 2012-02-20 04:11:32]

On 2012/02/20 03:50:57, bradfitz wrote:

> Why is LICENSE a binary file?
It's Rich Text. WiX reads the file into a dialog box and AFAICT only RTF looks
right.

[Joe Poirier, 2012-02-20 04:12:03]

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/README
File misc/dist/windows/README (right):

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/README#newc...
misc/dist/windows/README:23: Run dist.bat from a shell window or click on the
batch file.
On 2012/02/20 03:50:57, bradfitz wrote:
> s/shell/command prompt/?  (not cygwin, right?)
fixed

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat
File misc/dist/windows/dist.bat (right):

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat#ne...
misc/dist/windows/dist.bat:41: del /S /Q *.zip>NUL
On 2012/02/20 03:50:57, bradfitz wrote:
> is this always run from a temp directory where *.zip is safe to delete?  or
> should the pattern be more restrictive?
removed, not required

http://codereview.appspot.com/5673099/diff/4002/misc/dist/windows/dist.bat#ne...
misc/dist/windows/dist.bat:51: del /S /Q *.msi>NUL
On 2012/02/20 03:50:57, bradfitz wrote:
> likewise
removed, not required

[Joe Poirier, 2012-02-20 04:21:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=8ce97b044cfa ***

misc/dist/windows: ongoing dev

Added the (properly formatted) license file back,
the installer adds go\bin to the system PATH now,
the output package names are in line with the linux
and darwin versions, dist.bat extracts GOARCH in a
sane way, readme cleanup.

Tested on Windows 7 only. It would be helpful if
someone else could give it a try. See the readme
for details.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5673099