code review 5673090: os: document the type of link errors

os: document the type of link errors

[bradfitz, 2012-02-18 05:12:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-18 05:14:08]

http://codereview.appspot.com/5673090/diff/3002/src/pkg/os/file_posix.go
File src/pkg/os/file_posix.go (right):

http://codereview.appspot.com/5673090/diff/3002/src/pkg/os/file_posix.go#newc...
src/pkg/os/file_posix.go:41: // If there is an error, it will be of type
*LinkError.
it's not true in general. see the other implementations
i'll accept this change if you make it true.

[bradfitz, 2012-02-18 05:34:34]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-02-18 05:35:41]

On Fri, Feb 17, 2012 at 9:14 PM, <r@golang.org> wrote:

>
> http://codereview.appspot.com/**5673090/diff/3002/src/pkg/os/**
>
file_posix.go<http://codereview.appspot.com/5673090/diff/3002/src/pkg/os/file_posix.go>
> File src/pkg/os/file_posix.go (right):
>
> http://codereview.appspot.com/**5673090/diff/3002/src/pkg/os/**
>
file_posix.go#newcode41<http://codereview.appspot.com/5673090/diff/3002/src/pkg/os/file_posix.go#newcode41>
> src/pkg/os/file_posix.go:41: // If there is an error, it will be of type
> *LinkError.
> it's not true in general. see the other implementations
> i'll accept this change if you make it true.
>
>
Done.  plan9 updated.   I also fixed plan9's docs on Rename that promise a
PathError, which are wrong... on posix it's a LinkError.  So I just deleted
that line.

[r, 2012-02-18 06:37:56]

LGTM

[bradfitz, 2012-02-18 12:45:50]

*** Submitted as http://code.google.com/p/go/source/detail?r=eaad9c873d9b ***

os: document the type of link errors

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5673090