code review 5673068: syscall: force Windows to always use US English error messages

syscall: force Windows to always use US English error messages
Fixes issue 1834.

[minux1, 2012-02-16 11:27:11]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2012-02-16 18:02:15]

Related discussion:
http://groups.google.com/group/golang-nuts/browse_thread/thread/cf9727737e5b4...

[rsc, 2012-02-16 19:09:09]

Looks good to me.  Alex?

http://codereview.appspot.com/5673068/diff/4001/src/pkg/syscall/syscall_windo...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5673068/diff/4001/src/pkg/syscall/syscall_windo...
src/pkg/syscall/syscall_windows.go:80: func makelangid(pri, sub uint32) uint32 {
return sub<<10 | pri }
s/make//

[minux1, 2012-02-16 19:18:42]

On 2012/02/16 19:09:09, rsc wrote:
http://codereview.appspot.com/5673068/diff/4001/src/pkg/syscall/syscall_windo...
> File src/pkg/syscall/syscall_windows.go (right):
> 
>
http://codereview.appspot.com/5673068/diff/4001/src/pkg/syscall/syscall_windo...
> src/pkg/syscall/syscall_windows.go:80: func makelangid(pri, sub uint32) uint32
{
> return sub<<10 | pri }
> s/make//
done.

[brainman, 2012-02-16 22:33:13]

Fixes issue 1834?

Alex

http://codereview.appspot.com/5673068/diff/4/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5673068/diff/4/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:80: func langid(pri, sub uint32) uint32 {
return sub<<10 | pri }
It is, probably, makes no difference here, but

winnt.h:#define MAKELANGID(p,s) ((((WORD)(s))<<10)|(WORD)(p))

so, please

s/uint32/uint16/g

[minux1, 2012-02-17 16:01:57]

PTAL.

On 2012/02/16 22:33:13, brainman wrote:
> Fixes issue 1834?
Done.
> 
>
http://codereview.appspot.com/5673068/diff/4/src/pkg/syscall/syscall_windows.go
> File src/pkg/syscall/syscall_windows.go (right):
> 
>
http://codereview.appspot.com/5673068/diff/4/src/pkg/syscall/syscall_windows....
> src/pkg/syscall/syscall_windows.go:80: func langid(pri, sub uint32) uint32 {
> return sub<<10 | pri }
> It is, probably, makes no difference here, but
> 
> winnt.h:#define MAKELANGID(p,s) ((((WORD)(s))<<10)|(WORD)(p))
> 
> so, please
> 
> s/uint32/uint16/g
Done.

[brainman, 2012-02-19 22:50:46]

LGTM

Thank you

Alex

[brainman, 2012-02-19 22:51:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=998d434158dd ***

syscall: force Windows to always use US English error messages
Fixes issue 1834.

R=rsc, alex.brainman
CC=golang-dev
http://codereview.appspot.com/5673068

Committer: Alex Brainman <alex.brainman@gmail.com>