Issue 5673048: code review 5673048: build: keep environment variable changes local during W...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5673048: code review 5673048: build: keep environment variable changes local during W... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by brainman

Modified:
13 years, 11 months ago

Reviewers:

CC:
bradfitz, rsc, golang-dev

Visibility:
Public.

Description

build: keep environment variable changes local during Windows build

Patch Set 2 : diff -r 9639a3d73364 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9639a3d73364 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 3999d37bceb3 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	src/all.bat	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
	M	src/make.bat	View	1	3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2012-02-15 02:00:10 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5673048/diff/4001/src/make.bat File src/make.bat (right): http://codereview.appspot.com/5673048/diff/4001/src/make.bat#newcode9 src/make.bat:9: if x%2==x--no-local goto nolocal hah. :)

13 years, 11 months ago (2012-02-15 02:07:28 UTC) #2

brainman

On 2012/02/15 02:07:28, bradfitz wrote: > LGTM > Thank you Brad. But I will Russ ...

13 years, 11 months ago (2012-02-15 02:09:27 UTC) #3

rsc

Looks fantastic. We'll get the hang of this 1970s batch file thing yet. Probably run.bat ...

13 years, 11 months ago (2012-02-15 13:28:40 UTC) #4

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=8339ad24fb8d *** build: keep environment variable changes local during Windows build R=bradfitz, ...

13 years, 11 months ago (2012-02-15 23:26:07 UTC) #6

brainman

13 years, 11 months ago (2012-02-15 23:38:22 UTC) #7

On 2012/02/15 13:28:40, rsc wrote:
> 
> Probably run.bat should open with a setlocal too.

Like that http://codereview.appspot.com/5672061/ ?

Alex

Expand All Messages | Collapse All Messages