code review 5673045: runtime, time: accelerate tests in short mode.

runtime, time: accelerate tests in short mode.

                                   before   after
go test -short time                4.144s  1.215s
go test -short runtime             1.315s  0.351s
go test -short -cpu=1,2,4 runtime  4.376s  1.266s

Partially solves issue 3015.

[remyoudompheng, 2012-02-14 20:55:06]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-14 21:00:22]

LGTM

the runtime change seems fine.
i'm nervous the changes in the time tests will trigger build failures on slow
machines. tests like these tend to be fragile.
but we can try them and see.

[remyoudompheng, 2012-02-14 21:13:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=5cb1634cf037 ***

runtime, time: accelerate tests in short mode.

                                   before   after
go test -short time                4.144s  1.215s
go test -short runtime             1.315s  0.351s
go test -short -cpu=1,2,4 runtime  4.376s  1.266s

Partially solves issue 3015.

R=golang-dev, r
CC=golang-dev, remy
http://codereview.appspot.com/5673045

[brainman, 2012-02-15 01:48:42]

On 2012/02/14 21:13:43, remyoudompheng wrote:
> 
> runtime, time: accelerate tests in short mode.
> 

My short test fails now on windows/386:

--- FAIL: TestTicker (0.16 seconds)
        tick_test.go:29: 10 10ms ticks took 156.252ms, expected [80ms,120ms]

What should I do?

Alex

[r2, 2012-02-15 01:52:27]

On Feb 15, 2012, at 12:48 PM, alex.brainman@gmail.com wrote:

> On 2012/02/14 21:13:43, remyoudompheng wrote:
> 
>> runtime, time: accelerate tests in short mode.
> 
> 
> My short test fails now on windows/386:
> 
> --- FAIL: TestTicker (0.16 seconds)
>        tick_test.go:29: 10 10ms ticks took 156.252ms, expected
> [80ms,120ms]
> 
> What should I do?


as advertised, i was afraid of that. i think we need to roll back the TestTicker
change.

-rob

[brainman, 2012-02-15 01:54:00]

On 2012/02/15 01:52:27, r2 wrote:
> 
> ... i think we need to roll back the TestTicker
> change.

OK. I will change, test and send for review.

Alex