Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251)

Issue 5672068: Cleanup appengine_config.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by techtonik
Modified:
14 years, 4 months ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Cleanup appengine_config.py

Patch Set 1 #

Patch Set 2 : Django just requires it and it is documented #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M appengine_config.py View 1 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 9
techtonik
14 years, 4 months ago (2012-02-16 14:20:27 UTC) #1
M-A
rubberstamp lgtm, assuming it works.
14 years, 4 months ago (2012-02-16 15:59:06 UTC) #2
techtonik
Works fine for my local install. Forgot to add Guido - maybe he has objections ...
14 years, 4 months ago (2012-02-16 16:20:57 UTC) #3
GvR
LGTM (though I have no idea what the bug you quote in the comment is ...
14 years, 4 months ago (2012-02-16 17:39:07 UTC) #4
Andi Albrecht
On 2012/02/16 17:39:07, GvR wrote: > LGTM (though I have no idea what the bug ...
14 years, 4 months ago (2012-02-17 04:26:20 UTC) #5
techtonik
The stacktrace described in the bug appears in my 1.6.0 SDK when you first load ...
14 years, 4 months ago (2012-02-17 04:53:47 UTC) #6
techtonik
"Django 1.1 requires that the DJANGO_SETTINGS_MODULE environment variable be set.." http://code.google.com/appengine/docs/python/tools/libraries.html#Django Updated patch with a ...
14 years, 4 months ago (2012-02-17 06:07:25 UTC) #7
techtonik
Committed as a7a7f3bb87.
14 years, 4 months ago (2012-02-17 06:15:47 UTC) #8
gvrpython
14 years, 4 months ago (2012-02-18 02:56:37 UTC) #9
On Thu, Feb 16, 2012 at 10:07 PM,  <techtonik@gmail.com> wrote:
> I only wonder if the requirement for all "main" scripts to import
> webapp.template before django is still actual?

Switch to Python 2.7 and you won't need this any more...

-- 
--Guido van Rossum (python.org/~guido)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b