Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 5672062: code review 5672062: go/printer, go/fmt: simpler exprList code, more tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by gri
Modified:
13 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc1
Visibility:
Public.

Description

go/printer: simpler exprList code, more tests Except for the tests, this is mostly deleting code: - removed several exprListModes: blankStart: easily done explicitly, and trailing blanks are cleaned up by the trimmer post-pass blankEnd: never used commaSep: all exprLists calls had this set - added test cases for multi-line returns (for a later fix of issue 1207) - no formatting changes

Patch Set 1 #

Patch Set 2 : diff -r e9148f9e866e https://code.google.com/p/go #

Patch Set 3 : diff -r e9148f9e866e https://code.google.com/p/go #

Patch Set 4 : diff -r e9148f9e866e https://code.google.com/p/go #

Patch Set 5 : diff -r 92f4ca8f760c https://code.google.com/p/go #

Patch Set 6 : diff -r 60df364bae52 https://code.google.com/p/go #

Patch Set 7 : diff -r 60df364bae52 https://code.google.com/p/go #

Patch Set 8 : diff -r 60df364bae52 https://code.google.com/p/go #

Patch Set 9 : diff -r 60df364bae52 https://code.google.com/p/go #

Patch Set 10 : diff -r c741d60a882a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -47 lines) Patch
M src/pkg/go/printer/nodes.go View 1 2 3 4 5 6 7 8 15 chunks +30 lines, -47 lines 0 comments Download
M src/pkg/go/printer/testdata/statements.golden View 1 2 3 4 5 1 chunk +76 lines, -0 lines 0 comments Download
M src/pkg/go/printer/testdata/statements.input View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
13 years, 2 months ago (2012-03-01 19:42:43 UTC) #1
rsc1
LGTM
13 years, 2 months ago (2012-03-02 18:25:39 UTC) #2
gri
13 years, 2 months ago (2012-03-02 19:16:09 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d8586c9e6c89 ***

go/printer: simpler exprList code, more tests

Except for the tests, this is mostly deleting code:

- removed several exprListModes:
  blankStart: easily done explicitly, and trailing blanks
    are cleaned up by the trimmer post-pass
  blankEnd: never used
  commaSep: all exprLists calls had this set

- added test cases for multi-line returns
(for a later fix of issue 1207)

- no formatting changes

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5672062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b