Issue 5672050: code review 5672050: cmd/dist: use correct package target when cross-compiling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5672050: code review 5672050: cmd/dist: use correct package target when cross-compiling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by brainman

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/dist: use correct package target when cross-compiling

Patch Set 1 #

Patch Set 2 : diff -r 8fb6ce52511d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8fb6ce52511d https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/dist/build.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2012-02-15 05:47:49 UTC) #1

rsc

LGTM This might explain some other confusion we've been having. Thanks.

14 years, 1 month ago (2012-02-15 13:58:19 UTC) #2

rsc

14 years, 1 month ago (2012-02-15 14:02:48 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6341db42de48 ***

cmd/dist: use correct package target when cross-compiling

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5672050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages