code review 5672044: path, path/filepath: polish documentation.

path, path/filepath: polish documentation.

Fixes issue 2950.
Fixes issue 2951.

[remyoudompheng, 2012-02-14 21:51:49]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-16 00:44:34]

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go
File src/pkg/path/path.go (right):

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go#newcode103
src/pkg/path/path.go:103: // SplitList splits a list of paths joined by the
separator ':'.
this seems odd and specific, especially since strings already has the ability to
do this well. i'd say don't bother.

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go#newcode122
src/pkg/path/path.go:122: // separating slash if necessary. The result is
Cleaned, in particular
s/,/;/
s/$/,

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path_test.go#new...
src/pkg/path/path_test.go:88: t.Errorf("SplitList(%q) = %s, want %s", test.list,
l, test.result)
you could use %q throughout

[remyoudompheng, 2012-02-16 07:29:00]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[remyoudompheng, 2012-02-16 07:29:19]

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go
File src/pkg/path/path.go (right):

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go#newcode103
src/pkg/path/path.go:103: // SplitList splits a list of paths joined by the
separator ':'.
Removed.

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path.go#newcode122
src/pkg/path/path.go:122: // separating slash if necessary. The result is
Cleaned, in particular
On 2012/02/16 00:44:34, r wrote:
> s/,/;/
> s/$/,

Done.

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/5672044/diff/5001/src/pkg/path/path_test.go#new...
src/pkg/path/path_test.go:88: t.Errorf("SplitList(%q) = %s, want %s", test.list,
l, test.result)
Removed since I don't add SplitList anymore.

[r, 2012-02-16 12:30:49]

LGTM

[remyoudompheng, 2012-02-16 19:06:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=87b98f188120 ***

path, path/filepath: polish documentation.

Fixes issue 2950.
Fixes issue 2951.

R=golang-dev, r
CC=golang-dev, remy
http://codereview.appspot.com/5672044