Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 5671091: Makefile: Ultimate SDK detection patch. The following works: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by techtonik
Modified:
12 years, 12 months ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Makefile: Ultimate SDK detection patch. The following works: # if SDK is in ../google_appengine make serve # if SDK is in PATH make serve # if SDK is ../appengine/sdk SDK_PATH=../appengine/sdk make serve

Patch Set 1 #

Patch Set 2 : Ultimate Ultimate SDK detection patch. This enables coding various Makefile logic in Python #

Patch Set 3 : Fix comment #

Patch Set 4 : Simplify (thanks @MadScientist @ StackOverflow) #

Patch Set 5 : Comment is no more actual #

Patch Set 6 : NEWLINE define is not needed #

Patch Set 7 : .locally/ is meant to be inside rietveld/ checkout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Makefile View 1 2 3 4 5 6 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 8
techtonik
14 years, 3 months ago (2012-02-18 08:12:28 UTC) #1
GvR
By default the SDK installs in /usr/local/google_appengine, at least on Linux and Mac. (This is ...
14 years, 3 months ago (2012-02-18 18:00:13 UTC) #2
techtonik
I am not a Makefile guru, but I'll try if time permits. It feels wrong ...
14 years, 3 months ago (2012-02-18 20:57:35 UTC) #3
gvrpython
On Sat, Feb 18, 2012 at 12:57 PM, <techtonik@gmail.com> wrote: > I am not a ...
14 years, 3 months ago (2012-02-18 21:28:16 UTC) #4
techtonik
Here is the way to use Python from Makefile. All possible SDK paths are here. ...
12 years, 12 months ago (2013-06-15 16:08:06 UTC) #5
techtonik
Simplified a lot. Please take a look.
12 years, 12 months ago (2013-06-17 15:44:18 UTC) #6
M-A Ruel
On 2013/06/17 15:44:18, techtonik wrote: > Simplified a lot. Please take a look. Personally, lgtm
12 years, 12 months ago (2013-06-17 15:52:01 UTC) #7
techtonik
12 years, 12 months ago (2013-06-17 17:39:56 UTC) #8
Committed as a682007a3505. Thanks! ;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b