code review 5671076: log/syslog: disable on Windows

log/syslog: disable on Windows

We want to be able to implement good Windows support
after Go 1.  Right now Windows tries to use Unix domain
sockets, and I'd rather just have it not be available.

[rsc, 2012-02-17 02:52:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-17 02:54:26]

LGTM

On Fri, Feb 17, 2012 at 1:52 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> log/syslog: disable on Windows
>
> We want to be able to implement good Windows support
> after Go 1.  Right now Windows tries to use Unix domain
> sockets, and I'd rather just have it not be available.
>
> Please review this at
http://codereview.appspot.com/**5671076/<http://codereview.appspot.com/5671076/>
>
> Affected files:
>  M src/pkg/log/syslog/syslog.go
>  M src/pkg/log/syslog/syslog_**test.go
>
>
> Index: src/pkg/log/syslog/syslog.go
> ==============================**==============================**=======
> --- a/src/pkg/log/syslog/syslog.go
> +++ b/src/pkg/log/syslog/syslog.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build !windows,!plan9
> +
>  // Package syslog provides a simple interface to the system log service.
> It
>  // can send messages to the syslog daemon using UNIX domain sockets, UDP,
> or
>  // TCP connections.
> Index: src/pkg/log/syslog/syslog_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/log/syslog/syslog_**test.go
> +++ b/src/pkg/log/syslog/syslog_**test.go
> @@ -1,6 +1,9 @@
>  // Copyright 2009 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
> +
> +// +build !windows,!plan9
> +
>  package syslog
>
>  import (
>
>
>

[rsc, 2012-02-17 03:04:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=b984f2b4aa91 ***

log/syslog: disable on Windows

We want to be able to implement good Windows support
after Go 1.  Right now Windows tries to use Unix domain
sockets, and I'd rather just have it not be available.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5671076