code review 5671061: net/url: Rename ParseWithReference to ParseWithFragment.

net/url: Rename ParseWithReference to ParseWithFragment.

Updates issue 2946.

[dsymonds, 2012-02-16 04:40:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-02-16 04:41:23]

I went with "ParseWithFragment" instead of the suggested
"ParseFragment"; the latter is inaccurate because the function is
parsing a whole URL (with a fragment), not parsing a fragment.


Dave.

[r, 2012-02-16 04:41:56]

does the go 1 doc need an update?

[dsymonds, 2012-02-16 04:42:18]

http://codereview.appspot.com/5671061/diff/3003/src/cmd/fix/url2.go
File src/cmd/fix/url2.go (right):

http://codereview.appspot.com/5671061/diff/3003/src/cmd/fix/url2.go#newcode39
src/cmd/fix/url2.go:39: if sel.Sel.Name == "ParseWithReference" {
This might look a bit odd, but I hope to return here to rename the ParseRequest
function if we can come up with something better.

[dsymonds, 2012-02-16 04:42:35]

On 2012/02/16 04:41:56, r wrote:
> does the go 1 doc need an update?

Yes, will do.

[dsymonds, 2012-02-16 04:44:21]

On 2012/02/16 04:42:35, dsymonds wrote:
> On 2012/02/16 04:41:56, r wrote:
> > does the go 1 doc need an update?
> 
> Yes, will do.

Actually, I'm not sure it does. The package didn't even exist in r60.

[r2, 2012-02-16 04:46:14]

On Feb 16, 2012, at 3:41 PM, David Symonds wrote:

> I went with "ParseWithFragment" instead of the suggested
> "ParseFragment"; the latter is inaccurate because the function is
> parsing a whole URL (with a fragment), not parsing a fragment.

not a lovely name, although i don't have a better one.

-rob

[r2, 2012-02-16 04:47:44]

On Feb 16, 2012, at 3:44 PM, dsymonds@golang.org wrote:

> On 2012/02/16 04:42:35, dsymonds wrote:
>> On 2012/02/16 04:41:56, r wrote:
>> > does the go 1 doc need an update?
> 
>> Yes, will do.
> 
> Actually, I'm not sure it does. The package didn't even exist in r60.


but if the function has been renamed, it might be worth a mention. see the doc

-rob

[dsymonds, 2012-02-16 04:53:26]

Hello golang-dev@googlegroups.com, r@golang.org, r@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-16 04:54:51]

LGTM

[dsymonds, 2012-02-16 04:56:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=27d981f51226 ***

net/url: Rename ParseWithReference to ParseWithFragment.

Updates issue 2946.

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5671061