Issue 5671052: AddressSanitizer: remove pthread.h and signal.h on Mac in favor of declarations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5671052: AddressSanitizer: remove pthread.h and signal.h on Mac in favor of declarations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by samsonov

Modified:
12 years, 2 months ago

Reviewers:
ramosian.glider, glider, timurrrr_at_google_com, kcc

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Description

AddressSanitizer: remove pthread.h and signal.h on Mac in favor of declarations

Patch Set 1 #

Total comments: 3

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	asan_interceptors.cc	View		1 chunk	+9 lines, -3 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

samsonov

Kostya, just to make sure - is this CL fine on a path of cleaning ...

12 years, 2 months ago (2012-02-15 10:10:22 UTC) #1

glider

LGTM http://codereview.appspot.com/5671052/diff/1/asan_interceptors.cc File asan_interceptors.cc (right): http://codereview.appspot.com/5671052/diff/1/asan_interceptors.cc#newcode19 asan_interceptors.cc:19: #include "asan_mac.h" On 2012/02/15 10:10:22, samsonov wrote: > ...

12 years, 2 months ago (2012-02-15 10:17:03 UTC) #2

kcc

12 years, 2 months ago (2012-02-15 18:14:53 UTC) #3

http://codereview.appspot.com/5671052/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5671052/diff/1/asan_interceptors.cc#newcode37
asan_interceptors.cc:37: // intercepted functions. We need this declarations on
Mac to get addresses of
this->these
I also suggest to have the declarations adjacent to the interceptor definition
and not under ifdef __APPLE__.

Expand All Messages | Collapse All Messages