code review 5666048: reflect: fix panic strings

reflect: fix panic strings

use ':' instead of ';' to keep consistency with the other panic strings

[Lai Jiangshan, 2012-02-14 14:03:41]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-02-14 21:02:20]

LGTM
On Feb 15, 2012 1:18 AM, <eag0628@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> reflect: fix panic strings
>
> use ':' instead of ';' to keep consistency with the other panic strings
>
> Please review this at
http://codereview.appspot.com/**5666048/<http://codereview.appspot.com/5666048/>
>
> Affected files:
>  M src/pkg/reflect/type.go
>
>
> Index: src/pkg/reflect/type.go
> ==============================**==============================**=======
> --- a/src/pkg/reflect/type.go
> +++ b/src/pkg/reflect/type.go
> @@ -561,7 +561,7 @@
>                tt := (*sliceType)(unsafe.Pointer(t)**)
>                return toType(tt.elem)
>        }
> -       panic("reflect; Elem of invalid type")
> +       panic("reflect: Elem of invalid type")
>  }
>
>  func (t *commonType) Field(i int) StructField {
> @@ -630,7 +630,7 @@
>
>  func (t *commonType) NumIn() int {
>        if t.Kind() != Func {
> -               panic("reflect; NumIn of non-func type")
> +               panic("reflect: NumIn of non-func type")
>        }
>        tt := (*funcType)(unsafe.Pointer(t))
>        return len(tt.in)
> @@ -638,7 +638,7 @@
>
>  func (t *commonType) NumOut() int {
>        if t.Kind() != Func {
> -               panic("reflect; NumOut of non-func type")
> +               panic("reflect: NumOut of non-func type")
>        }
>        tt := (*funcType)(unsafe.Pointer(t))
>        return len(tt.out)
>
>
>

[r2, 2012-02-14 21:11:08]

You're not registered as a contributor, but this is such a small change, would
you mind if we just fixed the typos so you didn't need to fill in the CLA?  Of
course, if you want to become an official contributor, or are registered as one
under another name, that's fine too.

-rob

[r2, 2012-02-15 02:46:56]

i have made the change in http://codereview.appspot.com/5674047

[r, 2012-02-15 02:51:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=bfeb2a9eb288 ***

reflect: fix panic strings

use ':' instead of ';' to keep consistency with the other panic strings

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5666048

Committer: Rob Pike <r@golang.org>