code review 5665049: godoc: make godoc go work

godoc: make godoc go work

- if a package path leads to subdirectories only,
  show command instead, if any
- to force documentation for a command, use the
  cmd/ prefix, as in: godoc cmd/go
  (note that for the go command, the prefix is
  not required since there is no actual go library
  package at the moment)

Fixes issue 3012.

[gri, 2012-02-14 19:50:05]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-02-14 20:04:41]

Thanks for fixing this.  Instead of the -cmd flag, could we 
say that if the argument says 'cmd/foo' then we treat it as
"must be the command foo"?  This is the convention already
used in the go tool to identify commands, so it would avoid
introducing a second way.

[gri, 2012-02-14 20:12:30]

On Tue, Feb 14, 2012 at 12:04 PM,  <rsc@golang.org> wrote:
> Thanks for fixing this.  Instead of the -cmd flag, could we
> say that if the argument says 'cmd/foo' then we treat it as
> "must be the command foo"?  This is the convention already
> used in the go tool to identify commands, so it would avoid
> introducing a second way.
>
>
> http://codereview.appspot.com/5665049/

sure.

However this will prevent us from ever looking at a package directory "cmd".

- gri

[rsc, 2012-02-14 20:27:08]

On Tue, Feb 14, 2012 at 15:12, Robert Griesemer <gri@golang.org> wrote:
> However this will prevent us from ever looking at a package directory "cmd".

Yes, but the naming conventions used by the go tool already
burned that bridge.

Russ

[gri, 2012-02-14 20:35:04]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-02-14 20:36:34]

LGTM

[gri, 2012-02-14 21:57:23]

*** Submitted as 78d8f2f5e581 ***

godoc: make godoc go work

- if a package path leads to subdirectories only,
  show command instead, if any
- to force documentation for a command, use the
  cmd/ prefix, as in: godoc cmd/go
  (note that for the go command, the prefix is
  not required since there is no actual go library
  package at the moment)

Fixes issue 3012.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5665049