Issue 5661045: code review 5661045: goprotobuf: update to loss of unsafe.Unreflect, unsafe.New

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5661045: code review 5661045: goprotobuf: update to loss of unsafe.Unreflect, unsafe.New (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by r

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

goprotobuf: update to loss of unsafe.Unreflect, unsafe.New

Patch Set 2 : diff -r be6d136a075a https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 5808c60e90a0 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 5808c60e90a0 https://code.google.com/p/goprotobuf #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	proto/decode.go	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
	M	proto/encode.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 9 months ago (2012-02-13 20:43:09 UTC) #1

rsc

LGTM http://codereview.appspot.com/5661045/diff/1/proto/decode.go File proto/decode.go (right): http://codereview.appspot.com/5661045/diff/1/proto/decode.go#newcode638 proto/decode.go:638: bas := uintptr(reflect.New(typ).Pointer()) uintptr() should be redundant here ...

13 years, 9 months ago (2012-02-13 20:44:58 UTC) #2

13 years, 9 months ago (2012-02-13 21:14:25 UTC) #3

*** Submitted as 5340ad310031 ***

goprotobuf: update to loss of unsafe.Unreflect, unsafe.New

R=rsc
CC=golang-dev
http://codereview.appspot.com/5661045

Expand All Messages | Collapse All Messages