Issue 5656101: code review 5656101: time: use Go distribution zoneinfo if system copy not found

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5656101: code review 5656101: time: use Go distribution zoneinfo if system copy not found (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

time: use Go distribution zoneinfo if system copy not found Fixes issue 2964.

Patch Set 2 : diff -r f5cf68304beb https://code.google.com/p/go/ #

Patch Set 3 : diff -r f5cf68304beb https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 459d037686be https://code.google.com/p/go/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -266 lines)			Patch
M	src/pkg/time/zoneinfo.go	View	1 2 3	4 chunks	+17 lines, -5 lines	0 comments	Download
M	src/pkg/time/zoneinfo_plan9.go	View	1	3 chunks	+12 lines, -12 lines	0 comments	Download
M	src/pkg/time/zoneinfo_read.go	View	1	3 chunks	+1 line, -55 lines	0 comments	Download
M	src/pkg/time/zoneinfo_unix.go	View	1	2 chunks	+8 lines, -193 lines	0 comments	Download
M	src/pkg/time/zoneinfo_windows.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 4 months ago (2012-02-18 23:35:48 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5656101/diff/4001/src/pkg/time/zoneinfo.go File src/pkg/time/zoneinfo.go (right): http://codereview.appspot.com/5656101/diff/4001/src/pkg/time/zoneinfo.go#newcode199 src/pkg/time/zoneinfo.go:199: // BUG(rsc): The time zone database needed by ...

13 years, 4 months ago (2012-02-18 23:45:40 UTC) #2

rsc

13 years, 4 months ago (2012-02-19 02:02:44 UTC) #3

*** Submitted as 5cd9b3d5f9c9 ***

time: use Go distribution zoneinfo if system copy not found

Fixes issue 2964.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5656101

Expand All Messages | Collapse All Messages