Issue 5656075: Remove calls to library strtol/atoll from ASan RTL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5656075: Remove calls to library strtol/atoll from ASan RTL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by samsonov

Modified:
12 years, 2 months ago

Reviewers:
ramosian.glider, eugeni.stepanov, Evgeniy Stepanov

CC:
kcc, llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Patch Set 2 : (get rid of ctype.h, add check for overflow) #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -16 lines)			Patch
M	asan_interceptors.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	asan_interceptors.cc	View	1	3 chunks	+53 lines, -3 lines	0 comments	Download
M	asan_rtl.cc	View	1	2 chunks	+5 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Evgeniy Stepanov

http://codereview.appspot.com/5656075/diff/1/asan_interceptors.cc File asan_interceptors.cc (right): http://codereview.appspot.com/5656075/diff/1/asan_interceptors.cc#newcode107 asan_interceptors.cc:107: while (isspace(*nptr)) nptr++; Shall we avoid isspace, isdigit, etc ...

12 years, 2 months ago (2012-02-16 14:43:18 UTC) #2

samsonov

12 years, 2 months ago (2012-02-17 09:08:47 UTC) #3

LG

Expand All Messages | Collapse All Messages