code review 5656059: text/template: evaluate function fields

text/template: evaluate function fields
Just an oversight they didn't work and easy to address.

Fixes issue 3025.

[r, 2012-02-15 04:36:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-02-15 05:04:07]

LGTM

[r, 2012-02-15 05:05:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=a50806fa9040 ***

text/template: evaluate function fields
Just an oversight they didn't work and easy to address.

Fixes issue 3025.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5656059

[rsc, 2012-02-15 14:06:33]

This broke the go command's usage message.
It was using {{if .Run}} to test whether the field
was != nil, and now template wants to execute
the function.

I don't have a good solution.

[r2, 2012-02-15 23:26:58]

On Feb 16, 2012, at 1:06 AM, Russ Cox wrote:

> This broke the go command's usage message.
> It was using {{if .Run}} to test whether the field
> was != nil, and now template wants to execute
> the function.
> 
> I don't have a good solution.

i think the new behavior is what most would expect, which is unfortunate in this
instance.
in your case, a boolean method that checks p.Run == nil would solve it. i'll
send a CL.
i could make nil functions be false in the template package, but that would be
hacky and surprising.

-rob