code review 5655068: cmd/cgo: omit //line in -godefs, -cdefs output

cmd/cgo: omit //line in -godefs, -cdefs output

Makes files like src/pkg/syscall/ztypes_linux_amd64.go easier to read.
(The copy that is checked in predates the //line output mode,
so this also preserves the status quo.)

[rsc, 2012-02-13 19:00:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant2, 2012-02-13 19:10:46]

LGTM

rsc@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/cgo: omit //line in -godefs, -cdefs output
>
> Makes files like src/pkg/syscall/ztypes_linux_amd64.go easier to read.
> (The copy that is checked in predates the //line output mode,
> so this also preserves the status quo.)
>
> Please review this at http://codereview.appspot.com/5655068/
>
> Affected files:
>   M src/cmd/cgo/main.go
>
>
> Index: src/cmd/cgo/main.go
> ===================================================================
> --- a/src/cmd/cgo/main.go
> +++ b/src/cmd/cgo/main.go
> @@ -15,6 +15,7 @@
>  	"flag"
>  	"fmt"
>  	"go/ast"
> +	"go/printer"
>  	"go/token"
>  	"io"
>  	"os"
> @@ -158,6 +159,13 @@
>  		os.Exit(2)
>  	}
>
> +	if *godefs || *cdefs {
> +		// Generating definitions pulled from header files,
> +		// to be checked into Go repositories.
> +		// Line numbers are just noise.
> +		conf.Mode &^= printer.SourcePos
> +	}
> +
>  	args := flag.Args()
>  	if len(args) < 1 {
>  		usage()

[gri, 2012-02-13 19:11:43]

http://codereview.appspot.com/5655068/diff/3/src/cmd/cgo/main.go
File src/cmd/cgo/main.go (right):

http://codereview.appspot.com/5655068/diff/3/src/cmd/cgo/main.go#newcode8
src/cmd/cgo/main.go:8: //	Emit correct line number annotations.
This one can go presumably.

http://codereview.appspot.com/5655068/diff/3/src/cmd/cgo/main.go#newcode166
src/cmd/cgo/main.go:166: conf.Mode &^= printer.SourcePos
It seems cleaner to initialize conf here instead of fixing it after the fact.

[rsc, 2012-02-13 19:12:30]

On Mon, Feb 13, 2012 at 14:11,  <gri@golang.org> wrote:
> It seems cleaner to initialize conf here instead of fixing it after the
> fact.

Left as is; -cdefs and -godefs are the special case here;
the default is good.

[gri, 2012-02-13 19:22:32]

LGTM

Please update the TODO is necessary.

[rsc, 2012-02-13 19:23:00]

On Mon, Feb 13, 2012 at 14:22,  <gri@golang.org> wrote:
> Please update the TODO is necessary.

Will delete the entire TODO before submitting (wow that's old).

[rsc, 2012-02-13 21:02:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=e82fb8e5b5c8 ***

cmd/cgo: omit //line in -godefs, -cdefs output

Makes files like src/pkg/syscall/ztypes_linux_amd64.go easier to read.
(The copy that is checked in predates the //line output mode,
so this also preserves the status quo.)

R=golang-dev, iant, gri
CC=golang-dev
http://codereview.appspot.com/5655068