Issue 5655067: code review 5655067: go/printer, gofmt: don't indent line directives

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5655067: code review 5655067: go/printer, gofmt: don't indent line directives (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by gri

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: don't indent line directives This was broken by http://codereview.appspot.com/5643066 which introduced lazy indentation printing. Fixes issue 2990.

Patch Set 1 #

Patch Set 2 : diff -r 9d7addec2635 https://code.google.com/p/go #

Patch Set 3 : diff -r 9d7addec2635 https://code.google.com/p/go #

Patch Set 4 : diff -r bea4f55e688e https://code.google.com/p/go #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -27 lines)			Patch
M	src/pkg/go/printer/printer.go	View	1	4 chunks	+21 lines, -27 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

14 years, 4 months ago (2012-02-13 18:50:27 UTC) #1

gri

14 years, 4 months ago (2012-02-13 19:50:55 UTC) #3

*** Submitted as 17f57b6e8bf3 ***

go/printer, gofmt: don't indent line directives

This was broken by http://codereview.appspot.com/5643066
which introduced lazy indentation printing.

Fixes issue 2990.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5655067

Expand All Messages | Collapse All Messages