Issue 5655050: code review 5655050: compress: add comments to gzip and zlib.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5655050: code review 5655050: compress: add comments to gzip and zlib. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by nigeltao

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

compress: add comments to gzip and zlib. Fixes issue 2939.

Patch Set 1 #

Patch Set 2 : diff -r caf7dca9d711 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r caf7dca9d711 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6b9c66081c84 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
M	src/pkg/compress/gzip/gunzip.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/pkg/compress/gzip/gzip.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/compress/zlib/reader.go	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/pkg/compress/zlib/writer.go	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-02-10 08:22:52 UTC) #1

nigeltao

Another option is deleting the ErrChecksum types entirely and just inlining the errors.New calls. I ...

13 years, 3 months ago (2012-02-10 08:25:38 UTC) #2

rsc

LGTM On Fri, Feb 10, 2012 at 03:25, Nigel Tao <nigeltao@golang.org> wrote: > Another option ...

13 years, 3 months ago (2012-02-10 17:22:37 UTC) #3

On 11/02/2012, at 4:22 AM, Russ Cox wrote: > LGTM > > On Fri, Feb ...

13 years, 3 months ago (2012-02-10 20:26:36 UTC) #4

nigeltao

13 years, 3 months ago (2012-02-10 22:42:17 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=8dd8f41d4a7e ***

compress: add comments to gzip and zlib.

Fixes issue 2939.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5655050

Expand All Messages | Collapse All Messages