Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 5655047: code review 5655047: unicode: various documentation tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by r
Modified:
13 years, 3 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

unicode: various documentation tweaks The comment on IsOneOf regarding Latin-1 was an implementation detail: when the function is called internally, that condition is true. It used to matter, but now the comment is a dreg. The function works fine if the character is Latin-1, so we just delete the comment. Fixes issue 2966.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 9610105a2191 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/pkg/unicode/graphic.go View 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/unicode/letter.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/unicode/maketables.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/tables.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2012-02-10 03:21:13 UTC) #1
bradfitz
LGTM http://codereview.appspot.com/5655047/diff/1/src/pkg/unicode/letter.go File src/pkg/unicode/letter.go (right): http://codereview.appspot.com/5655047/diff/1/src/pkg/unicode/letter.go#newcode63 src/pkg/unicode/letter.go:63: //BUG(r): There is no mechanism for full case ...
13 years, 3 months ago (2012-02-10 03:29:02 UTC) #2
r
13 years, 3 months ago (2012-02-10 03:30:51 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b46573b5ec69 ***

unicode: various documentation tweaks

The comment on IsOneOf regarding Latin-1 was an implementation detail:
when the function is called internally, that condition is true. It used to
matter,
but now the comment is a dreg. The function works fine if the character is
Latin-1, so we just delete the comment.

Fixes issue 2966.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5655047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b