Issue 5654083: code review 5654083: cmd/vet: give warning for construct 'Println(os.Stderr,...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5654083: code review 5654083: cmd/vet: give warning for construct 'Println(os.Stderr,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by minux1

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/vet: give warning for construct 'Println(os.Stderr, ...)' also fixes this bug in net/http/httptest.

Patch Set 2 : diff -r 9d7addec2635 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9d7addec2635 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ae2ea46c2ba8 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r ae2ea46c2ba8 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/cmd/vet/print.go	View	1 2 3 4	1 chunk	+11 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/httptest/server.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-13 19:32:46 UTC) #1

LGTM http://codereview.appspot.com/5654083/diff/3001/src/cmd/vet/print.go File src/cmd/vet/print.go (right): http://codereview.appspot.com/5654083/diff/3001/src/cmd/vet/print.go#newcode217 src/cmd/vet/print.go:217: f.Warnf(call.Pos(), "the first argument to %s is %s.%s, ...

13 years, 4 months ago (2012-02-13 20:17:13 UTC) #2

minux1

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-02-13 20:32:04 UTC) #3

still LGTM http://codereview.appspot.com/5654083/diff/7002/src/cmd/vet/print.go File src/cmd/vet/print.go (right): http://codereview.appspot.com/5654083/diff/7002/src/cmd/vet/print.go#newcode217 src/cmd/vet/print.go:217: f.Warnf(call.Pos(), "the first argument to %s is ...

13 years, 4 months ago (2012-02-13 20:45:14 UTC) #4

minux1

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-02-13 20:56:05 UTC) #5

rsc

13 years, 4 months ago (2012-02-14 16:24:43 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=41905ae6e2d4 ***

cmd/vet: give warning for construct 'Println(os.Stderr, ...)'
        also fixes this bug in net/http/httptest.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5654083

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages