Issue 5654077: code review 5654077: text/template: drop reference to os.EPERM in the test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5654077: code review 5654077: text/template: drop reference to os.EPERM in the test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by r

Modified:
14 years, 5 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

text/template: drop reference to os.EPERM in the test

Patch Set 2 : diff -r 17f57b6e8bf3 https://go.googlecode.com/hg/ #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	src/pkg/text/template/exec_test.go	View	1	4 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 5 months ago (2012-02-13 11:45:20 UTC) #1

gri

LGTM http://codereview.appspot.com/5654077/diff/1/src/pkg/text/template/exec_test.go File src/pkg/text/template/exec_test.go (right): http://codereview.appspot.com/5654077/diff/1/src/pkg/text/template/exec_test.go#newcode421 src/pkg/text/template/exec_test.go:421: {"error method, error", "{{.Error true}}", "", tVal, false}, ...

14 years, 5 months ago (2012-02-13 16:56:36 UTC) #2

14 years, 5 months ago (2012-02-13 20:11:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ae2ea46c2ba8 ***

text/template: drop reference to os.EPERM in the test

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5654077

Expand All Messages | Collapse All Messages