Issue 5654065: code review 5654065: sync/atomic: disable hammer pointer tests on wrong size...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5654065: code review 5654065: sync/atomic: disable hammer pointer tests on wrong size... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by iant

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, dvyukov, golang-dev

Visibility:
Public.

Description

sync/atomic: disable hammer pointer tests on wrong size system hammerCompareAndSwapPointer64 was only passing on little-endian systems. hammerCompareAndSwapPointer32 was writing 8 bytes to a uint32 value on the heap.

Patch Set 1 #

Patch Set 2 : diff -r cbee2f341f10 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/sync/atomic/atomic_test.go	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc, dvyukov (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-12 04:28:48 UTC) #1

iant

13 years, 4 months ago (2012-02-13 05:53:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4fb39381b140 ***

sync/atomic: disable hammer pointer tests on wrong size system

hammerCompareAndSwapPointer64 was only passing on
little-endian systems.  hammerCompareAndSwapPointer32 was
writing 8 bytes to a uint32 value on the heap.

R=rsc, dvyukov
CC=golang-dev
http://codereview.appspot.com/5654065

Expand All Messages | Collapse All Messages