code review 5654046: exp/types: Use build.FindTree in GcImporter

exp/types: Use build.FindTree in GcImporter

Fixes issue 2932

[jnw, 2012-02-09 21:39:52]

Hello golang-devs@googlegroups.com (cc: golang-dev@googlegroups.com,
gri@golang.org, rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-09 21:43:22]

R=gri

[gri, 2012-02-10 19:30:34]

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (left):

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:44: 
please leave the empty line

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:53: 
please leave the empty line

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (right):

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:28: pkgRoot = filepath.Join(runtime.GOROOT(),
"pkg", runtime.GOOS+"_"+runtime.GOARCH)
this is not needed anymore

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:43: // "x" -> "$GOROOT/pkg/$GOOS_$GOARCH/x.ext",
"x"
this can go now

[jnw, 2012-02-10 19:46:32]

Hello gri@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[jnw, 2012-02-10 19:49:47]

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (left):

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:44: 
On 2012/02/10 19:30:35, gri wrote:
> please leave the empty line

Done.

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:53: 
On 2012/02/10 19:30:35, gri wrote:
> please leave the empty line

Done.

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (right):

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:28: pkgRoot = filepath.Join(runtime.GOROOT(),
"pkg", runtime.GOOS+"_"+runtime.GOARCH)
On 2012/02/10 19:30:35, gri wrote:
> this is not needed anymore

I'm fairly sure you're referring to pkgRoot here. It's moved in the test file,
so I've just constructed it ther.e

http://codereview.appspot.com/5654046/diff/3001/src/pkg/exp/types/gcimporter....
src/pkg/exp/types/gcimporter.go:43: // "x" -> "$GOROOT/pkg/$GOOS_$GOARCH/x.ext",
"x"
On 2012/02/10 19:30:35, gri wrote:
> this can go now

Done.

[jnw, 2012-02-10 19:50:09]

Hello gri@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2012-02-10 21:34:50]

LGTM

[gri, 2012-02-10 21:35:05]

*** Submitted as 3ec5c69a7f86 ***

exp/types: Use build.FindTree in GcImporter

Fixes issue 2932

R=gri
CC=golang-dev
http://codereview.appspot.com/5654046

Committer: Robert Griesemer <gri@golang.org>