Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
LGTM I am not convinced that parser.go changes are necessary: For one, the parser and the AST move in sync - it's unlikely there are issues here. But I guess it makes is a bit more readable. Please build gofmt after this change and run "go test" in the gofmt directory and also do "gofmt -l $GOROOT/src $GOROOT/misc" (there should be no changes) as a sanity check. Thanks. - gri http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/doc/reader.go File src/pkg/go/doc/reader.go (right): http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/doc/reader.go#newc... src/pkg/go/doc/reader.go:434: Lparen: token.NoPos, just leave away Lparen and Rparen (not setting it is == token.NoPos) http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/doc/reader.go#newc... src/pkg/go/doc/reader.go:526: typ = &ast.StarExpr{Star: token.NoPos, X: typ} leave away Star http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/parser/parser.go File src/pkg/go/parser/parser.go (right): http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/parser/parser.go#n... src/pkg/go/parser/parser.go:585: Incomplete: false, leave away Incomplete http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/parser/parser.go#n... src/pkg/go/parser/parser.go:802: Incomplete: false, leave away Incomplete http://codereview.appspot.com/5653073/diff/4001/src/pkg/go/parser/parser.go#n... src/pkg/go/parser/parser.go:1936: EndPos: token.NoPos, leave away EndPos
*** Submitted as http://code.google.com/p/go/source/detail?r=c9dae91ce714 *** cmd, pkg/go/*: fix "go vet" warnings for go/ast and go/printer struct literals. R=gri CC=golang-dev http://codereview.appspot.com/5653073
