Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 5653070: code review 5653070: net/http: document use of DetectContentType (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by rsc
Modified:
13 years, 10 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

net/http: document use of DetectContentType Fixes issue 2365.

Patch Set 1 #

Patch Set 2 : diff -r 4a0c77722a5e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8296cf56b8c1 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r f1e448eb63ae https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/pkg/net/http/server.go View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/net/http/sniff.go View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2012-02-13 03:32:35 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/5653070/diff/4001/src/pkg/net/http/sniff.go File src/pkg/net/http/sniff.go (right): http://codereview.appspot.com/5653070/diff/4001/src/pkg/net/http/sniff.go#newcode13 src/pkg/net/http/sniff.go:13: // References in this file refer to this ...
13 years, 10 months ago (2012-02-13 03:39:38 UTC) #2
rsc
13 years, 10 months ago (2012-02-13 04:14:50 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=1e1ac2e74216 ***

net/http: document use of DetectContentType

Fixes issue 2365.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5653070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b