Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 5653065: code review 5653065: gc: diagnose field+method of same name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: diagnose field+method of same name Fixes issue 2828.

Patch Set 1 #

Patch Set 2 : diff -r 872b07c91930 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 872b07c91930 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/cmd/gc/dcl.c View 1 1 chunk +8 lines, -0 lines 0 comments Download
A test/fixedbugs/bug416.go View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2012-02-11 06:21:10 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=4a0c77722a5e *** gc: diagnose field+method of same name Fixes issue 2828. R=ken2 ...
13 years, 4 months ago (2012-02-11 06:21:17 UTC) #2
ken3
13 years, 4 months ago (2012-02-11 09:53:06 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b