code review 5653053: strings: delete method comments implied by interface sa...

strings: delete method comments implied by interface satisfaction

Fixes issue 2957.

[r, 2012-02-10 03:36:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-10 03:38:36]

LGTM

On Fri, Feb 10, 2012 at 2:36 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> strings: delete method comments implied by interface satisfaction
>
> Fixes issue 2957.
>
> Please review this at
http://codereview.appspot.com/**5653053/<http://codereview.appspot.com/5653053/>
>
> Affected files:
>  M src/pkg/strings/reader.go
>
>
> Index: src/pkg/strings/reader.go
> ==============================**==============================**=======
> --- a/src/pkg/strings/reader.go
> +++ b/src/pkg/strings/reader.go
> @@ -50,9 +50,6 @@
>        return
>  }
>
> -// UnreadByte moves the reading position back by one byte.
> -// It is an error to call UnreadByte if nothing has been
> -// read yet.
>  func (r *Reader) UnreadByte() error {
>        if r.i <= 0 {
>                return errors.New("strings.Reader: at beginning of string")
> @@ -62,11 +59,6 @@
>        return nil
>  }
>
> -// ReadRune reads and returns the next UTF-8-encoded
> -// Unicode code point from the buffer.
> -// If no bytes are available, the error returned is io.EOF.
> -// If the bytes are an erroneous UTF-8 encoding, it
> -// consumes one byte and returns U+FFFD, 1.
>  func (r *Reader) ReadRune() (ch rune, size int, err error) {
>        if r.i >= len(r.s) {
>                return 0, 0, io.EOF
> @@ -81,9 +73,6 @@
>        return
>  }
>
> -// UnreadRune causes the next call to ReadRune to return the same rune
> -// as the previous call to ReadRune.
> -// The last method called on r must have been ReadRune.
>  func (r *Reader) UnreadRune() error {
>        if r.prevRune < 0 {
>                return errors.New("strings.Reader: previous operation was
> not ReadRune")
>
>
>

[r, 2012-02-10 03:45:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=044ac8070a6d ***

strings: delete method comments implied by interface satisfaction

Fixes issue 2957.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5653053