Issue 5652065: code review 5652065: gc: fix import of struct type in struct literal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5652065: code review 5652065: gc: fix import of struct type in struct literal (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:
Kyle E. Lemons, ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: fix import of struct type in struct literal Fixes issue 2716.

Patch Set 2 : diff -r 1b396c3b8f4a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dda14685cf36 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -164 lines)			Patch
M	src/cmd/gc/go.y	View	1	2 chunks	+17 lines, -1 line	1 comment	Download
M	src/cmd/gc/y.tab.c	View	1	142 chunks	+179 lines, -163 lines	0 comments	Download
A	test/fixedbugs/bug415.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug415.dir/main.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug415.dir/p.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-11 05:34:00 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=b400b5f53d68 *** gc: fix import of struct type in struct literal Fixes ...

13 years, 4 months ago (2012-02-11 05:34:04 UTC) #2

Kyle E. Lemons

FYI http://codereview.appspot.com/5652065/diff/5001/src/cmd/gc/go.y File src/cmd/gc/go.y (right): http://codereview.appspot.com/5652065/diff/5001/src/cmd/gc/go.y#newcode1422 src/cmd/gc/go.y:1422: NodeList *l; Is there code missing here? l ...

13 years, 4 months ago (2012-02-11 06:04:39 UTC) #4

Kyle E. Lemons

13 years, 4 months ago (2012-02-11 06:07:27 UTC) #5

On 2012/02/11 06:04:39, Kyle E. Lemons wrote:
> FYI
> 
> http://codereview.appspot.com/5652065/diff/5001/src/cmd/gc/go.y
> File src/cmd/gc/go.y (right):
> 
> http://codereview.appspot.com/5652065/diff/5001/src/cmd/gc/go.y#newcode1422
> src/cmd/gc/go.y:1422: NodeList *l;
> Is there code missing here?
> 
> l is used without being initialized... (either that or my C is really, really
> rusty)

Nevermind.  Fixed already.

Expand All Messages | Collapse All Messages