Issue 5651084: code review 5651084: os: rename SyscallError.Errno to SyscallError.Err

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5651084: code review 5651084: os: rename SyscallError.Errno to SyscallError.Err (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by ality

Modified:
14 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

os: rename SyscallError.Errno to SyscallError.Err This lets us get rid of the OS-dependent implementations of SyscallError. The name "Err" was chosen to match the PathError type.

Patch Set 1 #

Patch Set 2 : diff -r 78d9bba0ab24 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 78d9bba0ab24 https://code.google.com/p/go/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -37 lines)			Patch
M	src/pkg/os/error.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/pkg/os/error_plan9.go	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/pkg/os/error_posix.go	View	1	2 chunks	+1 line, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

14 years ago (2012-02-13 09:37:49 UTC) #1

rsc

14 years ago (2012-02-14 19:22:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0158e2415ca5 ***

os: rename SyscallError.Errno to SyscallError.Err

This lets us get rid of the OS-dependent implementations
of SyscallError.  The name "Err" was chosen to match the
PathError type.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5651084

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages